Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 )
Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8790/2/testdata/workloads/functional-query/queries/QueryTest/joins.test File testdata/workloads/functional-query/queries/QueryTest/joins.test: http://gerrit.cloudera.org:8080/#/c/8790/2/testdata/workloads/functional-query/queries/QueryTest/joins.test@774 PS2, Line 774: ---- QUERY > Are these queries effective in testing 'nan' != 'nan' only when codegen is disable_codegen_rows_threshold=0 is already set, as a default from ImpalaTestSuite::__create_exec_option_dimension I also verified that the test doesn't pass without the fix -- To view, visit http://gerrit.cloudera.org:8080/8790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bb8e5074b3c939927dedc46bc9db63ca24486a1 Gerrit-Change-Number: 8790 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 17:58:00 +0000 Gerrit-HasComments: Yes
