Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 )
Change subject: IMPALA-6291: disable AVX512 codegen in LLVM ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@110 PS2, Line 110: DEFINE_string(llvm_cpu_attr_whitelist, "sse2,cx16,prfchw,bmi2,fsgsbase,popcnt,aes,smap," > I think we should be doing that manually when we are confident that we'll b How do we ensure that codegen functions don't accidentally emit instructions not on the whitelist ? It appears that most of them are using CpuInfo::IsSupported() which doesn't seem to take into account of the whitelist here. http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@155 PS2, Line 155: target_features_attr_ My understanding is that even if we blacklisted some instructions not on the whitelist, this shouldn't affect the inlining logic as long as both caller and callee functions have the same attributes, right ? -- To view, visit http://gerrit.cloudera.org:8080/8802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a Gerrit-Change-Number: 8802 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 19:55:11 +0000 Gerrit-HasComments: Yes
