Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8747
to look at the new patch set (#5).
Change subject: IMPALA-5993: Fix the file offset in value parsing error
......................................................................
IMPALA-5993: Fix the file offset in value parsing error
This is to fix the file offset in value parsing error
messages when scanning text files. When the text scanner
hit an error, it always prints the end of the file as the
offset, even if the error occurs in the middle of the file.
This change also contains:
- Print errors column-wise instead of row-wise
- Adopt more user friendly message format
Testing:
Add two test cases:
- TestWrongFileOffset.test_parsing_wrong_text
- TestWrongFileOffset.test_parsing_wrong_gzip_text
Change-Id: I4a4ac3199ffe12fcce0bf792b3e6ce529b9af61f
---
M be/src/exec/hdfs-scanner-ir.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-scanner.h
M be/src/exec/hdfs-sequence-scanner.cc
M testdata/data/README
A testdata/data/problematic_rows_impala_5993.csv
A testdata/data/problematic_rows_impala_5993.csv.gz
M tests/query_test/test_scanners.py
8 files changed, 300 insertions(+), 53 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/8747/5
--
To view, visit http://gerrit.cloudera.org:8080/8747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a4ac3199ffe12fcce0bf792b3e6ce529b9af61f
Gerrit-Change-Number: 8747
Gerrit-PatchSet: 5
Gerrit-Owner: Kim Jin Chul <[email protected]>
Gerrit-Reviewer: Kim Jin Chul <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
