John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )
Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@400 PS2, Line 400: Strips off fields from a <codeph>TIMESTAMP</codeph> value > Can we use "truncates" not "strips off"? Done http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@406 PS2, Line 406: Tabs! Don't know how those got in there. http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@455 PS2, Line 455: select now(), date_trunc('microseconds', now()); : +-------------------------------+-----------------------------------+ : | now() | date_trunc('microseconds', now()) | : +-------------------------------+-----------------------------------+ : | 2017-12-05 13:58:04.565403000 | 2017-12-05 13:58:04.565403000 | : +-------------------------------+-----------------------------------+ > now() never returns any nanosecond values so probably not a great example Wow, even after I added the Note: above, I was fooled by the singular/plural business. I.e. thinking that 'microseconds' must set microseconds to zero rather setting everything _below_ a microsecond to zero. I'll add a little wording earlier on to reinforce where the precision boundary is. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: sandeep akinapelli <[email protected]> Gerrit-Comment-Date: Mon, 11 Dec 2017 19:46:18 +0000 Gerrit-HasComments: Yes
