Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 )
Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc@334 PS2, Line 334: IntGauge* negated_bytes_in_use = new NegatedGauge<int64_t>( > We should add the gauges to obj_pool_. Done http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc@334 PS2, Line 334: new NegatedGauge<int64_t> > Is this leaked ? Done http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc@340 PS2, Line 340: new SumGauge<int64_t> > Is this also leaked ? Done http://gerrit.cloudera.org:8080/#/c/8782/2/be/src/runtime/exec-env.cc@344 PS2, Line 344: tcmalloc_overhead > We need to be careful about the order in which this MemTracker and tcmalloc added both to obj_pool -- To view, visit http://gerrit.cloudera.org:8080/8782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I602e9d5e8e8d7470dcfe4addde3265057c16263a Gerrit-Change-Number: 8782 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 11 Dec 2017 22:56:12 +0000 Gerrit-HasComments: Yes
