Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 )
Change subject: IMPALA-4132: Use -fno-omit-frame-pointer ...................................................................... Patch Set 2: I played around a bit with inducing crashes in my dev environment with partially stripped impalad binaries (--strip-debug). It seems like breakpad does a reasonable job of resolving the stack trace as long as you have symbols extracted from a binary (even the --strip-debug option). I picked an arbitrary spot to crash at though so not sure if it is just an easy one or if that will generalise. However, if we don't have the symbols, without the frame pointer minidump_stackwalk can't unwind the stack at all. With the frame pointer, it reliably unwinds the stack, although it can't symbolise it because it doesn't have symbols. -- To view, visit http://gerrit.cloudera.org:8080/8612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d0d88ba015a847356ed0274fe91017b98cb941 Gerrit-Change-Number: 8612 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2017 02:02:00 +0000 Gerrit-HasComments: No
