Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 )
Change subject: IMPALA-3703: Store query context in thread-local variables ...................................................................... Patch Set 5: (4 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/8621/5/be/src/common/thread-debug-info.h File be/src/common/thread-debug-info.h: http://gerrit.cloudera.org:8080/#/c/8621/5/be/src/common/thread-debug-info.h@81 PS5, Line 81: /// it cuts off the ending of the string > Would it make sense to keep the last few bytes of the string and truncate i OK, I keep the last N bytes instead of the first N bytes. http://gerrit.cloudera.org:8080/#/c/8621/4/be/src/common/thread-info.h File be/src/common/thread-info.h: http://gerrit.cloudera.org:8080/#/c/8621/4/be/src/common/thread-info.h@56 PS4, Line 56: > I feel that having separate members may make it easier to use this in debug I added this functionality to provide an easy way to add more information. But I think you are right, if someone wants to add some extra information, they will add a new data member to this class. http://gerrit.cloudera.org:8080/#/c/8621/4/be/src/common/thread-info.h@103 PS4, Line 103: > See my comment above about special purpose members. Done, I removed the text field. http://gerrit.cloudera.org:8080/#/c/8621/4/be/src/common/thread-info.h@104 PS4, Line 104: > I agree that it's helpful to keep these as a string. Is there a benefit fro I don't think there is any benefit here since we only store char buffers. Also, it is not the performance critical part of impala. I changed it to 34. -- To view, visit http://gerrit.cloudera.org:8080/8621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I566f7f1db5117c498e86e0bd05b33bdcff624609 Gerrit-Change-Number: 8621 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Dec 2017 16:02:25 +0000 Gerrit-HasComments: Yes
