Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 )
Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/8569/9/bin/rat_exclude_files.txt File bin/rat_exclude_files.txt: http://gerrit.cloudera.org:8080/#/c/8569/9/bin/rat_exclude_files.txt@24 PS9, Line 24: be/src/thirdparty/mpfit/* The license part of the DISCLAIMER file needs to be put in LICENSE.txt in order for the comment on line 22 of this file to be accurate. http://gerrit.cloudera.org:8080/#/c/8569/9/bin/run_clang_tidy.sh File bin/run_clang_tidy.sh: http://gerrit.cloudera.org:8080/#/c/8569/9/bin/run_clang_tidy.sh@58 PS9, Line 58: # I think this is leftovers. -- To view, visit http://gerrit.cloudera.org:8080/8569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia51d56ee67ec6073e92f90bebb4005484138b820 Gerrit-Change-Number: 8569 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 17:49:35 +0000 Gerrit-HasComments: Yes
