Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8817 )
Change subject: IMPALA-6308: Fix bad Status() usage in data-stream-sender.cc ...................................................................... IMPALA-6308: Fix bad Status() usage in data-stream-sender.cc Previously, DataStreamSender::FlushAndSendEos() makes some wrong assumption about the format string of the error status returned from DoTransmitDataRpc(). In particular, it assumes that the format string has exactly one substitution argument. This is a pretty bad assumption as new types of errors could be returned from DoTransmitDataRpc() and they can take different numbers of substitution arguments. Recent changes in the format string TErrorCode::RPC_RECV_TIMEOUT exposed this bug. This change fixes the problem by removing this bad usage of Status() in data-stream-sender.cc Change-Id: I1cc04db670069a7df484e2f2bafb93c5315b9c82 Reviewed-on: http://gerrit.cloudera.org:8080/8817 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/data-stream-sender.cc 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1cc04db670069a7df484e2f2bafb93c5315b9c82 Gerrit-Change-Number: 8817 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
