Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 )
Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. ...................................................................... Patch Set 3: (1 comment) Reviving this, after it got bumped down by higher priority tasks. Please take a look at patch set #4. http://gerrit.cloudera.org:8080/#/c/8349/3/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8349/3/be/src/exprs/string-functions-ir.cc@443 PS3, Line 443: bitset<256>* unique_chars = new bitset<256>; : unique_chars->set(static_cast<int>(' '), true); > It seems unnecessary overhead to do this for every row. Done. This does mean that the old trim functions now require prepare and close functions. -- To view, visit http://gerrit.cloudera.org:8080/8349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a5ae3f59762e70c3268a01e14ed57a9e36b8d79 Gerrit-Change-Number: 8349 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2017 00:03:13 +0000 Gerrit-HasComments: Yes
