Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8260 )
Change subject: PREVIEW: IMPALA-6052: Change HDFS layout for test tables ...................................................................... Patch Set 3: (2 comments) The direction here seems fine to me. This is a case where I think you'll need to run both exhaustive and S3 tests before commit, since this is so very cross-cutting. What's the bigger picture of what brought you here? http://gerrit.cloudera.org:8080/#/c/8260/3/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/8260/3/testdata/bin/generate-schema-statements.py@470 PS3, Line 470: p = subprocess.Popen(['/bin/bash', '-c', cmd], stdout=subprocess.PIPE) this is missing stderr=subprocess.PIPE, so stderr is always going to be None in the line below. http://gerrit.cloudera.org:8080/#/c/8260/3/testdata/bin/generate-schema-statements.py@473 PS3, Line 473: if p.returncode != 0: : print "eval_section command failed: {0}".format(cmd) : assert(False) nit: I think this is equivalent to: if p.returncode != 0: raise Exception("...") you can also do assert False, "message". -- To view, visit http://gerrit.cloudera.org:8080/8260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ba27ba6d3c7e445795e750281070963bbe1bb51 Gerrit-Change-Number: 8260 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2017 21:27:37 +0000 Gerrit-HasComments: Yes
