Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 )
Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8836/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8836/1/be/src/exprs/aggregate-functions-ir.cc@388 PS1, Line 388: DCHECK_EQ(dst->len, sizeof(DecimalAvgState)); Did you test on a debug build? I think there's a constant in the FE that needs to be updated too (DECIMAL_AVG_INTERMEDIATE_SIZE). This DCHECK is meant to assert that the fe and be sizes are the same. -- To view, visit http://gerrit.cloudera.org:8080/8836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id25ec6e20dde3f50fb37a22135b355ad251809e0 Gerrit-Change-Number: 8836 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 17:50:35 +0000 Gerrit-HasComments: Yes
