Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8752 )
Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations ...................................................................... Patch Set 2: Code-Review+1 (5 comments) I'm pretty happy with this change. I'm sure we can keep making improvements but I think it would be good to get this change committed to let it bake. That should not stop us from considering additional improvements to the structure/comments. I encourage reviewers to keep posting improvement ideas. http://gerrit.cloudera.org:8080/#/c/8752/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8752/2/be/src/service/impala-server.h@339 PS2, Line 339: // Wait until the minimum catalog object version in the local cache exceeds /// style in the local cache is greater than or equal to 'min_catalog_update_version' http://gerrit.cloudera.org:8080/#/c/8752/1/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/8752/1/common/thrift/StatestoreService.thrift@88 PS1, Line 88: // non-delta TTopicDelta's since the latest version of every still-present topic item > No, an optimization was added at some point to avoid sending deletions for So then should the second sentence start with "When true..."? http://gerrit.cloudera.org:8080/#/c/8752/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/8752/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@93 PS2, Line 93: * Periodically, the CatalogServiceCatalog collects a delta of catalog updates (based on a Thanks! This is really clear to me now. http://gerrit.cloudera.org:8080/#/c/8752/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@95 PS2, Line 95: * Each catalog topic update is defined by a range of catalog versions [from, to) and the (from, to] http://gerrit.cloudera.org:8080/#/c/8752/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@96 PS2, Line 96: * CatalogServiceCatalog guarantees that very catalog object that has a version in the typo: every -- To view, visit http://gerrit.cloudera.org:8080/8752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12467a83acaeca6a127491d89291dedba91a35a Gerrit-Change-Number: 8752 Gerrit-PatchSet: 2 Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2017 23:56:07 +0000 Gerrit-HasComments: Yes
