Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 )
Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/8676/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/8676/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@495 PS8, Line 495: ParserErrorOnInsertStmtHints("insert %s into t %s select * from t", I didn't add a similar test for UPSERT here because it can be a duplicate. The purpose of the test is to check hints syntax (not for INSERT/UPSERT statements). -- To view, visit http://gerrit.cloudera.org:8080/8676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20 Gerrit-Change-Number: 8676 Gerrit-PatchSet: 8 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Sat, 16 Dec 2017 12:57:26 +0000 Gerrit-HasComments: Yes
