Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8853 )
Change subject: Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io. ...................................................................... Patch Set 2: (3 comments) Thanks for the review, Thomas. Good catch on IMPALA_JAVA_THRIFT_VERSION. I updated the change, and added the commons.io change which was hanging out uncommitted. https://jenkins.impala.io/job/gerrit-verify-dryrun-external/40/ is running with this new patch http://gerrit.cloudera.org:8080/#/c/8853/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/8853/2/bin/impala-config.sh@142 PS2, Line 142: IMPALA_THRIFT_JAVA_VERSION > Is this still being used anywhere now? Should have been :) http://gerrit.cloudera.org:8080/#/c/8853/2/impala-parent/pom.xml File impala-parent/pom.xml: http://gerrit.cloudera.org:8080/#/c/8853/2/impala-parent/pom.xml@48 PS2, Line 48: <commons-io.version>2.4</commons-io.version> I changed this too; missed a diff in my first post. http://gerrit.cloudera.org:8080/#/c/8853/2/impala-parent/pom.xml@57 PS2, Line 57: 0.9.0< > Should this be env.IMPALA_THRIFT_VERSION? Good eye; this should be IMPALA_JAVA_THRIFT_VERSION. -- To view, visit http://gerrit.cloudera.org:8080/8853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I717e0625dfe0fdbf7e9161312e9e80f405a359c5 Gerrit-Change-Number: 8853 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 19 Dec 2017 19:01:46 +0000 Gerrit-HasComments: Yes
