Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )
Change subject: Move symlinked auxiliary tests/* to tests/functional/* ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8896/1/bin/create-test-configuration.sh File bin/create-test-configuration.sh: http://gerrit.cloudera.org:8080/#/c/8896/1/bin/create-test-configuration.sh@194 PS1, Line 194: symlink_subdirs ${IMPALA_AUX_TEST_HOME}/tests/functional ${IMPALA_HOME}/tests Since any users of this would need to update their repositories, do you want to preserve the old behavior if tests/functional doesn't exist? i.e., if [ -e ${IMPALA_AUX_TEST_HOME}/tests/functional} ]; then symlink_subdirs ${IMPALA_AUX_TEST_HOME}/tests/functional ${IMPALA_HOME}/tests else # For compatibility with older auxiliary tests, which aren't in the functional subdirectory. symlink_subdirs ${IMPALA_AUX_TEST_HOME}/tests ${IMPALA_HOME}/tests fi -- To view, visit http://gerrit.cloudera.org:8080/8896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b Gerrit-Change-Number: 8896 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 23:04:53 +0000 Gerrit-HasComments: Yes
