Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 )
Change subject: IMPALA-6300: Fix decimal modulo overflow ...................................................................... Patch Set 4: Code-Review+2 (2 comments) I have only minor comments http://gerrit.cloudera.org:8080/#/c/8833/4/be/src/benchmarks/overflow-benchmark.cc File be/src/benchmarks/overflow-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/8833/4/be/src/benchmarks/overflow-benchmark.cc@137 PS4, Line 137: return false; This now always returns false. http://gerrit.cloudera.org:8080/#/c/8833/4/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: http://gerrit.cloudera.org:8080/#/c/8833/4/be/src/runtime/decimal-value.inline.h@186 PS4, Line 186: return num_lz - floor_log2[scale_diff] - 1; num_lz - floor_log2[scale_diff] - (scale_diff > 0) is slightly nicer, but may not matter since I don't think this is ever called for scale_diff == 0 -- To view, visit http://gerrit.cloudera.org:8080/8833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27c7f25f68353c19c315e1639311ec06b2dea686 Gerrit-Change-Number: 8833 Gerrit-PatchSet: 4 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2017 01:28:24 +0000 Gerrit-HasComments: Yes
