Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 )
Change subject: IMPALA-6190/6246: Add instances tab and event sequence ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8758/10/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/8758/10/be/src/runtime/fragment-instance-state.cc@222 PS10, Line 222: RETURN_IF_ERROR(codegen->FinalizeModule()); > We need to undo this change, we deliberately had the the heavyweight codege Would you mind elaborating on the point about "deliberately had the heavyweight codegen in Open()" ? Now that I look at it again, I realize moving it here could block callers waiting for prepared_promise_ to be set to True, which includes cancellation requests. Lars, sorry for missing that. That said, is there any reason why we cannot move the relatively lightweight codegen work in Prepare() to Open() ? -- To view, visit http://gerrit.cloudera.org:8080/8758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I626456b6afa9101eeeeffd5cda10c4096d63d7f9 Gerrit-Change-Number: 8758 Gerrit-PatchSet: 10 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 03 Jan 2018 18:22:39 +0000 Gerrit-HasComments: Yes
