Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 )
Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command ...................................................................... Patch Set 3: (2 comments) The build has run successfully. https://jenkins.impala.io/job/gerrit-verify-dryrun-external/55/ http://gerrit.cloudera.org:8080/#/c/8928/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/8928/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2231 PS1, Line 2231: private boolean alterTableSetFileFormat(Table tbl, > I guess you might use the code in this function. I think there are some red I had originally tried to reuse this code but the file format is a different set of parameters that the serde info as part of the storage descriptor and I thought trying to combine them would be confusing. http://gerrit.cloudera.org:8080/#/c/8928/1/tests/query_test/test_delimited_text.py File tests/query_test/test_delimited_text.py: http://gerrit.cloudera.org:8080/#/c/8928/1/tests/query_test/test_delimited_text.py@164 PS1, Line 164: def test_delimited_text_partitioned(self, vector, unique_database): > This test is very similar to test_delimited_text_alter. Do you refactor the This test is specific to data that is partitioned. -- To view, visit http://gerrit.cloudera.org:8080/8928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154 Gerrit-Change-Number: 8928 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2018 03:27:42 +0000 Gerrit-HasComments: Yes
