Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 )
Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock ...................................................................... Patch Set 1: (1 comment) I was able to come up with a regression test, thanks for the suggestion, it seems like the right thing to do. http://gerrit.cloudera.org:8080/#/c/8933/1/be/src/runtime/bufferpool/reservation-tracker.cc File be/src/runtime/bufferpool/reservation-tracker.cc: http://gerrit.cloudera.org:8080/#/c/8933/1/be/src/runtime/bufferpool/reservation-tracker.cc@209 PS1, Line 209: parent_ > I think it is possible to get to this point and have parent_ == nullptr This isn't possible because of how the ReservationTracker is initialised - InitRootTracker() doesn't take a MemTracker* argument. This is confusing though. I restructured the branches to make the invariant more obvious. -- To view, visit http://gerrit.cloudera.org:8080/8933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7adbe961a925075422c685690dd3d1609779ced Gerrit-Change-Number: 8933 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2018 16:12:00 +0000 Gerrit-HasComments: Yes
