Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8933 )
Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock ...................................................................... IMPALA-6362: avoid Reservation/MemTracker deadlock Avoid the circular dependency between ReservationTracker::lock_ and MemTracker::child_trackers_lock_ by not acquiring ReservationTracker::lock_ in GetReservation(), where an atomic operation is sufficient. Testing: Added a unit test that reproed the deadlock. Change-Id: Id7adbe961a925075422c685690dd3d1609779ced Reviewed-on: http://gerrit.cloudera.org:8080/8933 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/runtime/bufferpool/reservation-tracker-test.cc M be/src/runtime/bufferpool/reservation-tracker.cc M be/src/runtime/bufferpool/reservation-tracker.h M be/src/util/memory-metrics.cc M be/src/util/memory-metrics.h 5 files changed, 75 insertions(+), 15 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id7adbe961a925075422c685690dd3d1609779ced Gerrit-Change-Number: 8933 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
