Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 )
Change subject: IMPALA-3651: Adds murmur_hash() built-in function ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8893/4/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/8893/4/testdata/workloads/functional-query/queries/QueryTest/exprs.test@2922 PS4, Line 2922: select murmur_hash(NULL) > Tests like this belong in expr-test.cc Done, thanks for your advice. -- To view, visit http://gerrit.cloudera.org:8080/8893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14d56ffb8fab256f3f66a2669271fd4b3c50cc29 Gerrit-Change-Number: 8893 Gerrit-PatchSet: 4 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sun, 07 Jan 2018 07:11:39 +0000 Gerrit-HasComments: Yes