John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 )
Change subject: IMPALA-1767: [DOCS] Document new Boolean operators ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/8942/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/8942/2/docs/shared/impala_common.xml@779 PS2, Line 779: <codeph>IS [NOT] FALSE</codeph> as equivalents for the functions > "builtin functions" instead of "functions" to match the blurb in the detail Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml File docs/topics/impala_operators.xml: http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1251 PS2, Line 1251: lets > nit: let Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1320 PS2, Line 1320: lets > nit: let Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1327 PS2, Line 1327: These operators are equivalent to the built-in conditional functions > sync this blurb with the one in the index (see comment there). Done. I'll reuse the wording verbatim with a conref= attribute. http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1337 PS2, Line 1337: query error > must be same error as for "IS [NOT] NULL" for complex types? perhaps its le Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1345 PS2, Line 1345: select assertion, b, b is true, b is false, b is unknown : from boolean_test; > just for my own info, but why is this lower-case whereas sql inlined in tex I usually save the strict uppercase-keyword style for the detailed syntax blocks. Especially for built-in functions, I use mostly lowercase to be modern-looking like C code. -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 10 Jan 2018 05:42:25 +0000 Gerrit-HasComments: Yes
