Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 )
Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8991/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/8991/3/be/src/common/init.cc@262 PS3, Line 262: MallocExtension::instance()->SetNumericProperty( : "tcmalloc.aggressive_memory_decommit", 1); This actually causes a linking issue in libfesupport.so which isn't linked against the tcmalloc library. FE tests will fail due to unresolved symbols. Two possible ways of fixing it: - Move this initialization somewhere - Fix CMakeList.txt of libCommon.a to add a dependency on tcmallocstatic but this will make IMPALA_LINK_LIBS_DYNAMIC_TARGETS moot as it explicitly avoids linking against tcmalloc library due to the use of JVM but I cannot quite understand the reasoning of the comments as we statically link against tcmalloc library: # The above link list does not include tcmalloc. This is because the Impala JVM support # libraries (libfesupport, libloggingsupport) cannot use tcmalloc in all cases. When they # are started up by the FE (for tests) the jvm has already made allocations before # tcmalloc can be loaded. In all other binaries, we can use tcmalloc except the address # sanitizer build. Address sanitizer is incompatible with tcmalloc (they both intercept # malloc/free) -- To view, visit http://gerrit.cloudera.org:8080/8991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5be574435af51fb7a875b16888cca260b341190e Gerrit-Change-Number: 8991 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 11 Jan 2018 22:12:11 +0000 Gerrit-HasComments: Yes
