Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8771 )

Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell
......................................................................


Patch Set 3:

(1 comment)

What is here now is fine, but I think one piece of functionality is missing. 
See the inline comment.

http://gerrit.cloudera.org:8080/#/c/8771/3/docs/topics/impala_shell_options.xml
File docs/topics/impala_shell_options.xml:

http://gerrit.cloudera.org:8080/#/c/8771/3/docs/topics/impala_shell_options.xml@627
PS3, Line 627:
Somewhere in this section you should mention the new [impala.query_options] 
setting in impalarc. See for example 
https://gerrit.cloudera.org/#/c/8038/19/shell/option_parser.py L22.



--
To view, visit http://gerrit.cloudera.org:8080/8771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b
Gerrit-Change-Number: 8771
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: John Russell <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Comment-Date: Fri, 12 Jan 2018 00:00:30 +0000
Gerrit-HasComments: Yes

Reply via email to