Taras Bobrovytsky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9017 )

Change subject: IMPALA-6388: Fix the Union node number of hosts estimation
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9017/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test:

http://gerrit.cloudera.org:8080/#/c/9017/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test@3563
PS1, Line 3563: select coalesce(int_col, int_col) from functional.alltypes
> Why? If both operands are passthrough, then the order would stay the same r
That's true. In my view having a coalesce in both queries on different operands 
makes it explicit and more clear in my view.

Do you think it makes it more confusing?



--
To view, visit http://gerrit.cloudera.org:8080/9017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e1ecca8dbc84b2b5a72708667b2799d00279f0
Gerrit-Change-Number: 9017
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 21:17:56 +0000
Gerrit-HasComments: Yes

Reply via email to