Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 )
Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. ...................................................................... Patch Set 9: (3 comments) Thanks. Please see patch set 9. http://gerrit.cloudera.org:8080/#/c/8349/8/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8349/8/be/src/exprs/string-functions-ir.cc@410 PS8, Line 410: // There can be either 1 or 2 arguments. > Please DCHECK(context->GetNumArgs() == 1 or context->GetNumArgs() == 2); Done http://gerrit.cloudera.org:8080/#/c/8349/8/be/src/exprs/string-functions-ir.cc@436 PS8, Line 436: const StringVal& str, const StringVal& chars_to_trim) { > Seems that this line can be moved. If str.len == 0, the while loop will tak Done http://gerrit.cloudera.org:8080/#/c/8349/8/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/8349/8/be/src/exprs/string-functions.h@153 PS8, Line 153: , is true when the set of characters : /// to trim is constant. > is true when the set of characters to trim is constant. Done -- To view, visit http://gerrit.cloudera.org:8080/8349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a5ae3f59762e70c3268a01e14ed57a9e36b8d79 Gerrit-Change-Number: 8349 Gerrit-PatchSet: 9 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Sat, 13 Jan 2018 00:19:48 +0000 Gerrit-HasComments: Yes
