Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 )
Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/8400/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8400/8//COMMIT_MSG@20 PS8, Line 20: to nit: wrong word? http://gerrit.cloudera.org:8080/#/c/8400/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/8400/6/fe/src/main/cup/sql-parser.cup@1055 PS6, Line 1055: eate_tbl_as_sele > Does opt_plan_hints not work here? nit: please check that all review comments are marked as "Done" when sending out replies. http://gerrit.cloudera.org:8080/#/c/8400/6/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java: http://gerrit.cloudera.org:8080/#/c/8400/6/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java@69 PS6, Line 69: * Helper class for parsing. > It is still needed, as it is the result value of non-terminal create_tbl_as Thanks for the explanation, I think I understand it now. Could we just have a setter for the plan hints in CreateTableAsSelectStmt and then call stmt.AddHints(hints) inside the "create_tbl_as_select_stmt" rule? That way we don't have to add another class, the change would be smaller, and the parsing code easier to follow. http://gerrit.cloudera.org:8080/#/c/8400/8/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java: http://gerrit.cloudera.org:8080/#/c/8400/8/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java@71 PS8, Line 71: rules that checks nit: "rule that checks" or "rules that check" http://gerrit.cloudera.org:8080/#/c/8400/8/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java@75 PS8, Line 75: CTASParams nit: we generally seem to use camel case for acronyms, e.g. see createCtasTarget below. http://gerrit.cloudera.org:8080/#/c/8400/6/testdata/workloads/functional-planner/queries/PlannerTest/ddl.test File testdata/workloads/functional-planner/queries/PlannerTest/ddl.test: http://gerrit.cloudera.org:8080/#/c/8400/6/testdata/workloads/functional-planner/queries/PlannerTest/ddl.test@344 PS6, Line 344: 01:SORT > I should add a comment about this, but I am unsure whether it should be a s Yes, I think it's intentional. Maybe the docs need to be more clear. Can you open a docs JIRA? -- To view, visit http://gerrit.cloudera.org:8080/8400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d74bca999da8ae1bb89427c70841f33e3c56ab0 Gerrit-Change-Number: 8400 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jan 2018 20:35:26 +0000 Gerrit-HasComments: Yes
