Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 )
Change subject: IMPALA-6377: Bump breakpad version to include fix for #752 ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (3 comments) Carrying Sailesh's +2, verified in a private build. http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@7 PS1, Line 7: #752 > Could you add a link for this? Done http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@8 PS1, Line 8: > Not sure if you do this on every version bump, but it would be good to incl I added a note. Copying patches over for new versions seems to be a common pattern in the toolchain. http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@9 PS1, Line 9: This change bumps the Breakpad version in the toolchain to pull in the : fix for https://bugs. > Add that the PPC patch will get re-added in a later commit, after the patch Done -- To view, visit http://gerrit.cloudera.org:8080/9036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b Gerrit-Change-Number: 9036 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2018 22:02:55 +0000 Gerrit-HasComments: Yes
