Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9035 )
Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4 ...................................................................... Patch Set 1: (3 comments) Thanks! Minor comments below. We had considerably more patches for older Thrift. Have you reviewed that we don't need any of them? Thanks! http://gerrit.cloudera.org:8080/#/c/9035/1/source/bison/build.sh File source/bison/build.sh: http://gerrit.cloudera.org:8080/#/c/9035/1/source/bison/build.sh@2 PS1, Line 2: # Copyright 2015 Cloudera Inc. It's 2018. http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh File source/thrift/build.sh: http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh@38 PS1, Line 38: read OPENSSL_MAJ_VER OPENSSL_MIN_VER OPENSSL_PATCH_VER <<< `openssl version | \ This section requires comments. When is this happening and what's it doing? http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh@63 PS1, Line 63: ./configure \ This CONFIGURE_OUTPUT=$(...) trick is weird and hard to spot. I think $BUILD_LOG is where the output of 'wrap' goes, so you can just grep that in line 90-97 and life will be more obvious. -- To view, visit http://gerrit.cloudera.org:8080/9035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd Gerrit-Change-Number: 9035 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2018 22:58:54 +0000 Gerrit-HasComments: Yes
