Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8985 )
Change subject: IMPALA-5478: Run TPCDS queries with decimal_v2 enabled ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8985/2/tests/query_test/test_tpcds_queries.py File tests/query_test/test_tpcds_queries.py: http://gerrit.cloudera.org:8080/#/c/8985/2/tests/query_test/test_tpcds_queries.py@279 PS2, Line 279: v.get_value('table_format').compression_type != 'record') : cls.ImpalaTestMatrix.add_mandatory_exec_option('decimal_v2', 1) : : if cls.exploration_strategy() != 'exhaustive': > That's how we run the normal TPCDS workload. Are you suggesting to run this Nevermind, misread something. Done. http://gerrit.cloudera.org:8080/#/c/8985/2/tests/query_test/test_tpcds_queries.py@285 PS2, Line 285: cls.ImpalaTestMatrix.add_constraint(lambda v:\ : v.get_value('table_format').file_format in ['parquet']) : : cls.ImpalaTestMatrix.add_constraint(lambda v:\ : v.get_value('exec_option')['batch_size'] == 0) : : def test_tpcds_q1(self, vector): : self.run_test_case(self.get_workload() + '-decimal > Simlar response to above. Are you suggesting to run this workload different Done -- To view, visit http://gerrit.cloudera.org:8080/8985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib867c51a521ec4a087bc127d99aee4b95ba97733 Gerrit-Change-Number: 8985 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 16:52:46 +0000 Gerrit-HasComments: Yes
