Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 )
Change subject: IMPALA-5191: Standardize column alias behavior ...................................................................... Patch Set 12: Code-Review+2 (1 comment) I'l merge after you address the final comment. Can you file a JIRA and work with John Russell to get the new behavior documented? We should document it as an incompatible change. http://gerrit.cloudera.org:8080/#/c/8801/12/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/8801/12/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1056 PS12, Line 1056: // Constant arithmetic expressions should not be interpreted as ordinals Constant exprs should not be interpreted as ordinals. (this does not only apply to constant arithmetic exprs, but any constant expr, e.g. if(true,1,int_col) should also not be interpreted as an ordinal) -- To view, visit http://gerrit.cloudera.org:8080/8801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f82483b486acf6953876cfa672b0d034f3709a8 Gerrit-Change-Number: 8801 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 18:57:47 +0000 Gerrit-HasComments: Yes
