Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 )
Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8971/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8971/3//COMMIT_MSG@12 PS3, Line 12: > Should we be adding any context related to the coordinator problem here? That's a fair point. I think the new JIRAs and links should make it clearer, so we can leave this. http://gerrit.cloudera.org:8080/#/c/8971/3/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/8971/3/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@263 PS3, Line 263: .sum(planTreeProfile.duringOpenProfile.max(fInstancePostOpenProfile)); > I think this would achieve the same. Just takes the max of duringOpenProfil Hm, oh right, the max() is nested inside the sum() instead of after it. http://gerrit.cloudera.org:8080/#/c/8971/3/testdata/workloads/functional-planner/queries/PlannerTest/disable-codegen.test File testdata/workloads/functional-planner/queries/PlannerTest/disable-codegen.test: http://gerrit.cloudera.org:8080/#/c/8971/3/testdata/workloads/functional-planner/queries/PlannerTest/disable-codegen.test@59 PS3, Line 59: partitions=24/24 files=24 size=174.39KB > these sizes seem to change across test runs, maybe due to changes in data l I missed that this file had some expected changes to memory. http://gerrit.cloudera.org:8080/#/c/8971/3/testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test File testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test: PS3: > Changes to this file (and some of the later ones) look spurious too. I did another path. The changes to this file look like they're only to size, which is ignored by the test validation. I think we should revert changes to this file, because it's unrelated. -- To view, visit http://gerrit.cloudera.org:8080/8971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea2759665fb2e8bef9433014a8d42a7ebf99ce1f Gerrit-Change-Number: 8971 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Jan 2018 21:22:33 +0000 Gerrit-HasComments: Yes
