Hello Sailesh Mukil, Zoram Thanga, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079 to look at the new patch set (#3). Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps ...................................................................... IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps In the previous fix for IMPALA-6399 we increased the number of retries. However, there was a bug in the retry logic: If the profile was missing, we would call 'continue' without sleeping, thus eating through the maximum number of retries in a short period of time. This change now switches to a time-based wait-loop instead of a set number of retries. It also moves the sleep() to the beginning of the loop to make it less likely to forget it when changing the code in the future. Calling sleep() before trying to fetch the profile for the first time also reduces the likelihood of hitting a warning when the profile is not yet available. We also change the timeout back to 60 seconds which should be enough for the profile to show up. Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389 --- M tests/query_test/test_observability.py 1 file changed, 16 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/3 -- To view, visit http://gerrit.cloudera.org:8080/9079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389 Gerrit-Change-Number: 9079 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>