Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 )
Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8950/3/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/8950/3/be/src/runtime/data-stream-test.cc@703 PS3, Line 703: FLAGS_datastream_service_num_deserialization_threads = 1; : FLAGS_datastream_service_deserialization_queue_size = 1; > So this class is not reusable for other tests. It's hard to make a class th This alternative is not ideal either. I guess this is not too important for now so I am okay with the current approach given we document on why it's built this way. http://gerrit.cloudera.org:8080/#/c/8950/5/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/8950/5/be/src/runtime/data-stream-test.cc@658 PS5, Line 658: info.status = sender.Send(&s Given there is nothing special about this class, may be this should be called DataStreamTestThriftOnly ? -- To view, visit http://gerrit.cloudera.org:8080/8950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d1a8f12a4821092ca61ccc8a6f20c0404d56c7 Gerrit-Change-Number: 8950 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Sat, 20 Jan 2018 03:12:02 +0000 Gerrit-HasComments: Yes
