Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 )
Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata ...................................................................... Patch Set 1: I see that this patch fixes some inconsistencies in the code but if you take a look at all the ddl statements, it's kind of random which return a result set ('summary') and which don't. My thinking is that if we want to go down that path we should establish a consistent behavior across all statements. The other concern with this patch is about testing. How do you know if this change will break some clients? How do you plan to test this? -- To view, visit http://gerrit.cloudera.org:8080/9090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic542fb8e49e850052416ac663ee329ee3974e3b9 Gerrit-Change-Number: 9090 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Jan 2018 20:30:34 +0000 Gerrit-HasComments: No