Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 )
Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Thanks! I'll merge after you've addressed the final change. http://gerrit.cloudera.org:8080/#/c/8818/8/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java File fe/src/main/java/org/apache/impala/analysis/StringLiteral.java: http://gerrit.cloudera.org:8080/#/c/8818/8/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@92 PS8, Line 92: * String literal can come directly from the SQL of a query or from rewrites like Some grammar issues, suggest this correction: String literals can come directly from the SQL of a query or from rewrites like constant folding. So this value normalization to a single-quoted string is necessary because we do not know whether single or double quotes are appropriate. -- To view, visit http://gerrit.cloudera.org:8080/8818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc4b5f5d8ffaa8feb96a466959427a04b3b06fec Gerrit-Change-Number: 8818 Gerrit-PatchSet: 8 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Jan 2018 02:15:37 +0000 Gerrit-HasComments: Yes
