Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9114
Change subject: IMPALA-6429: Fix decimal division ...................................................................... IMPALA-6429: Fix decimal division Before this patch, it was possible for an overflow to not be detected when doing a decimal division. When scaling up the dividend before doing the division, we do not check for overflow. This is ok if the we are scaling up by 10^38 or less because the result is guaranteed to fit into 256 bits. However, when we are scaling up by more than 38, the result may not fit into 256 bits and overflow. This overflow may not be detected. The problem is fixed by checking for overflow when scaling up the dividend. Testing: - Added some BE tests Change-Id: Ibd1075d9c78986cd975dd29c1125d71ba6560c23 --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h M be/src/util/decimal-util.h 3 files changed, 46 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/9114/1 -- To view, visit http://gerrit.cloudera.org:8080/9114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd1075d9c78986cd975dd29c1125d71ba6560c23 Gerrit-Change-Number: 9114 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <[email protected]>
