John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 )
Change subject: [DOCS] Doc for MURMUR_HASH() function ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@871 PS1, Line 871: https://en.wikipedia.org/wiki/MurmurHash Could you add an entry in ../impala_keydefs.ditamap for this wiki page, following the format of the other <keydef> tags referencing Wikipedia articles? Although we haven't switched the <xref> tags pointing to external pages, we might in future start using the more compact <xref keyref="mnemonic"/> form instead of filling out the full URL in the topic file. http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@878 PS1, Line 878: You might use the return value Is there some aspect of performance, collisions, or similar that would influence the decision of whether to use murmur_hash() or fnv_hash()? http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@907 PS1, Line 907: relatively low entropy Is this statement really true for murmur_hash()? For fnv_hash(), the corresponding example shows the same leading digits '206202...' for the hashed value of both True and False. -- To view, visit http://gerrit.cloudera.org:8080/9031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b Gerrit-Change-Number: 9031 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jan 2018 19:52:18 +0000 Gerrit-HasComments: Yes
