Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 )
Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9125/1/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9125/1/be/src/rpc/rpc-mgr.cc@47 PS1, Line 47: DECLARE_int32(rpc_duration_too_long_ms); > Can you add a comment saying that this is a KRPC flag? Done http://gerrit.cloudera.org:8080/#/c/9125/1/be/src/rpc/rpc-mgr.cc@60 PS1, Line 60: FLAGS_rpc_duration_too_long_ms = 15 * 60 * 1000; > I think the default of 15 minutes is too long, since we have noticed querie Do you think 5 or 10 minutes would be more reasonable ? -- To view, visit http://gerrit.cloudera.org:8080/9125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I347b0dea641368e10ba84bc40ec250c26a4f43b2 Gerrit-Change-Number: 9125 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jan 2018 23:04:37 +0000 Gerrit-HasComments: Yes
