Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 )
Change subject: IMPALA-4835: prerequisite buffer pool changes ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/9097/2/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: http://gerrit.cloudera.org:8080/#/c/9097/2/be/src/runtime/bufferpool/buffer-pool-test.cc@767 PS2, Line 767: handle This refers to BufferHandle, not ClientHandle, right ? If so, please state it explicitly. http://gerrit.cloudera.org:8080/#/c/9097/2/be/src/runtime/bufferpool/buffer-pool-test.cc@797 PS2, Line 797: } ASSERT_TRUE(handle.is_open()); http://gerrit.cloudera.org:8080/#/c/9097/2/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: http://gerrit.cloudera.org:8080/#/c/9097/2/be/src/runtime/bufferpool/buffer-pool.h@231 PS2, Line 231: WARN_UNUSED_RESULT nit: long line. Not needed ? -- To view, visit http://gerrit.cloudera.org:8080/9097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f2196722df59f2d367787c0550058022e296e24 Gerrit-Change-Number: 9097 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jan 2018 02:25:22 +0000 Gerrit-HasComments: Yes
