Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9059 )
Change subject: IMPALA-6383: free memory after skipping parquet row groups ...................................................................... IMPALA-6383: free memory after skipping parquet row groups Before this patch, resources were only flushed after breaking out of NextRowGroup(). This is a problem because resources can be allocated for skipped row groups (e.g. for reading dictionaries). Testing: Tested in conjunction with a prototype buffer pool patch that was DCHECKing before the change. Added DCHECKs to the current version to ensure the streams are cleared up as expected. Ran the repro for IMPALA-6419 to confirm this iteration of the patch fixed the original problem. Change-Id: I95713675455f7635fa3f72616b166f35e2a46c1a Reviewed-on: http://gerrit.cloudera.org:8080/9059 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/exec/scanner-context.h 3 files changed, 44 insertions(+), 21 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I95713675455f7635fa3f72616b166f35e2a46c1a Gerrit-Change-Number: 9059 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
