Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py@107 PS2, Line 107: .* I don't think we want an unlimited number of chars (the "*" operator). I think we want this regex: "Cherry-pick.?:.?not (for|to) {branch}" http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py@236 PS2, Line 236: skip_commits_matching = options.skip_commits_matching.replace( I think makes more sense to use format here. This should work: options.skip_commits_matching.format(branch=options.target_branch) -- To view, visit http://gerrit.cloudera.org:8080/9135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05 Gerrit-Change-Number: 9135 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 20:11:24 +0000 Gerrit-HasComments: Yes
