Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9130 )
Change subject: IMPALA-6410: Use subprocess in compare_branches.py. ...................................................................... IMPALA-6410: Use subprocess in compare_branches.py. Switches bin/compare_branches.py to use 'subprocess' instead of 'sh'. We often use 'sh' in Impala testing code for its friendly API, but it has to be installed separately. To avoid automation that is just doing git operations needing to either build the Impala python environment or otherwise get extra libraries, I converted the usages. As a side-effect, the script outputs the stdout of 'git cherry-pick', whereas it used to swallow it. I like it better this way. I tested this by running it in an environment which needed some cherry-picks. Change-Id: I509a548a129e7ad67aaf800a8ba03cffad51dd81 Reviewed-on: http://gerrit.cloudera.org:8080/9130 Reviewed-by: Jim Apple <[email protected]> Tested-by: Impala Public Jenkins --- M bin/compare_branches.py 1 file changed, 12 insertions(+), 10 deletions(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I509a548a129e7ad67aaf800a8ba03cffad51dd81 Gerrit-Change-Number: 9130 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]>
