Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 )
Change subject: IMPALA-2642: Fix a potential deadlock in statestore ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py File tests/custom_cluster/test_custom_statestore.py: http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@34 PS3, Line 34: from thrift.transport import TSocket, TTransport : > one line Done http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@39 PS3, Line 39: : LOG = logging.getLogger('custom_statestore_test') > Needed? Removed. http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@42 PS3, Line 42: > Needed? Removed http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@52 PS3, Line 52: _, port = handle.getsockname() : : @classmethod : def get_workload(self): > Does this mean that every "statestore subscriber" uses the same port? Looks That's correct. All the subscribers we create below will connect from the same port number, but with different subscriber IDs. Is that ok with you? It seems simpler and puts less load on the system than creating a new port every time. -- To view, visit http://gerrit.cloudera.org:8080/9038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d49dede221ce1f50ec299643b5532c61f93f0c6 Gerrit-Change-Number: 9038 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Mon, 29 Jan 2018 20:39:54 +0000 Gerrit-HasComments: Yes
