Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 )
Change subject: IMPALA-6215: Removes race when using LibCache. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9089/5/be/src/runtime/lib-cache.h File be/src/runtime/lib-cache.h: http://gerrit.cloudera.org:8080/#/c/9089/5/be/src/runtime/lib-cache.h@78 PS5, Line 78: /// '*entry' is expected to be null. The caller must call DecrementUseCount(*entry) : /// when it is done using 'path'. is the 'entry' opaque to the caller and only used to decrement the reference count? if so, maybe we should make this parameter be a handle class that's effectively the scope exit thing and handles the reference counting for us. That way, a callsite can't forget to decrement, and each callsite doesn't have to define the same scope exit handler code itself. -- To view, visit http://gerrit.cloudera.org:8080/9089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9175085201fe8b11424ab8f88d7b992cb7b0daea Gerrit-Change-Number: 9089 Gerrit-PatchSet: 5 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 29 Jan 2018 21:45:41 +0000 Gerrit-HasComments: Yes
