Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9150 )

Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions
......................................................................

IMPALA-6447: remove Python 2.7 dictionary comprehensions

In the fix for IMPALA-6441, we began importing from the stress test
(concurrent_select.py). The import fails on some downstream environments
that use Python 2.6. The failure is due to the fact that
concurrent_select.py uses a few dictionary comprehensions, a language
feature introduced in Python 2.7.

This problem wasn't caught upstream, because upstream is using
Python2.7.

The fix is to remove the dictionary comprehensions and create the
dictionaries in a more backward-compatible way. The problematic import
succeeds on Python 2.6.

Change-Id: I3174e1bd1b6ac007b345d42474401af50d006a52
Reviewed-on: http://gerrit.cloudera.org:8080/9150
Reviewed-by: Dimitris Tsirogiannis <[email protected]>
Reviewed-by: David Knupp <[email protected]>
Tested-by: Impala Public Jenkins
---
M tests/comparison/query_profile.py
M tests/stress/concurrent_select.py
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Dimitris Tsirogiannis: Looks good to me, but someone else must approve
  David Knupp: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3174e1bd1b6ac007b345d42474401af50d006a52
Gerrit-Change-Number: 9150
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>

Reply via email to