Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 )
Change subject: IMPALA-5237: Support a quoted string in date/time format ...................................................................... Patch Set 8: (5 comments) Applied the update. http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.h@189 PS7, Line 189: // function finishes str pointer is changed to point to the closing quote. > This sentence is not needed in my opinion. Done http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.h@190 PS7, Line 190: // position_of_string_literal -- start position of the string literal. > str is assumed to point to... Done http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.h@192 PS7, Line 192: // string_literal_begin -- start pointer of the string literal if there is a pair of > some separator between the param name and it's description would be great. Done http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.cc@161 PS7, Line 161: const char** str, int* position_of_string_literal, int* length_of_string_literal, > One thing I learned recently, that in Impala the out parameters are preferr You're right. Actually, Tim already answered the similar question on this change: https://gerrit.cloudera.org/#/c/8770/2/be/src/exec/data-sink.cc http://gerrit.cloudera.org:8080/#/c/8508/7/be/src/runtime/timestamp-parse-util.cc@203 PS7, Line 203: // str is to point to the closing quote and the incrementing points to the first > It might worth a comment here that incrementing this would result in the st Done -- To view, visit http://gerrit.cloudera.org:8080/8508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 Gerrit-Change-Number: 8508 Gerrit-PatchSet: 8 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2018 09:19:01 +0000 Gerrit-HasComments: Yes
