Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 )
Change subject: IMPALA-3562: support column restriction for compute stats ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9133/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/9133/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@358 PS3, Line 358: col.getName() + " of complex type:" + col.getType().prettyPrint()); prettyPrint() is what produces the DESCRIBE output Let's use toSql() instead of prettyPrint() because prettyPrint() may add newlines and make the error look awkward. -- To view, visit http://gerrit.cloudera.org:8080/9133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8b25dd248e578dc7ddd35468125cca12d1b9f27 Gerrit-Change-Number: 9133 Gerrit-PatchSet: 3 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2018 16:59:51 +0000 Gerrit-HasComments: Yes
