Lars Volker has posted comments on this change. (
http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 2:
(2 comments)
I convinced myself with the following command that the flags aren't used
anywhere anymore:
tail -n 27 be/src/common/global-flags.cc | cut -d '(' -f 2 | cut -d ')' -f 1
| while read f; do git grep FLAGS_$f; done
http://gerrit.cloudera.org:8080/#/c/9173/2//COMMIT_MSG
Commit Message:
PS2:
Should give the flags an honorary mention in the commit message so that they
become searchable in git log?
http://gerrit.cloudera.org:8080/#/c/9173/2/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:
http://gerrit.cloudera.org:8080/#/c/9173/2/be/src/common/global-flags.cc@209
PS2, Line 209: jgs
I like this! However, I suspect jgs refers to stuff from this website:
http://www.oocities.org/spunk1111/
Does the copyright allow us to include it here?
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:28:21 +0000
Gerrit-HasComments: Yes
